Minimal rate-limiting on create-user / create-room - #28
Merged
Conversation
- lib/ratelimit.ts: fixed-window KV limiter (per-IP, fails open on KV errors; no write once over the limit so writes stay bounded) - POST /api/users -> 20/min/IP, POST /api/rooms -> 30/min/IP; over limit -> 429 - health -> v3.6 Tested local: 21st user-create in a minute returns 429.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app is public, so casual spam could pile up rows in D1. Adds a fixed-window KV rate limiter (per client IP) on the two write endpoints:
POST /api/users→ 20/min/IPPOST /api/rooms→ 30/min/IP429Best-effort: fails open on a KV hiccup (never blocks real users), and stops writing once over the limit so KV writes stay bounded. For serious abuse, Cloudflare WAF rate-limiting rules are the proper next step.
Tested local: the 21st create-user within a minute returns 429 (20×201 then 429). lint/typecheck/build ✅. health → v3.6.