Add AI ask tool + use new timeout on AI tool - #440
Open
freekh wants to merge 1 commit into
Open
Conversation
|
Contributor
Author
|
Make sure ask tool has a cancel button |
freekh
commented
Jul 28, 2026
| !store.hasAllLoaded(moduleIds) | ||
| ) { | ||
| React.use(store.waitForLoad(moduleIds)); | ||
| console.log("->", valOverlayContext.enabled, store?.hasAllLoaded(moduleIds)); |
freekh
commented
Jul 28, 2026
| }: { | ||
| params: Promise<{ blog: string }>; | ||
| }) { | ||
| console.log("here"); |
freekh
commented
Jul 28, 2026
| const blog = useValRoute(blogsVal, params); | ||
| const authors = useVal(authorsVal); | ||
| if (!blog) { | ||
| console.log("not found"); |
freekh
commented
Jul 28, 2026
| chat: { | ||
| experimental: { | ||
| enable: false, | ||
| enable: true, |
Contributor
Author
There was a problem hiding this comment.
Revert back to false
freekh
commented
Jul 28, 2026
| _toolCallId: string, | ||
| answers: AskUserQuestionAnswer[], | ||
| ) => { | ||
| console.log("Submitted answers:", answers); |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Val UI AI chat/tooling layer by introducing a new ask_user_question tool (with a question-card UI) and by adding support for per-tool server-side timeouts via timeoutMs in the tool definition schema.
Changes:
- Added
ask_user_questionas a first-class AI tool, including UI rendering for structured single-/multi-select questions and callbacks to submit/cancel answers. - Extended the AI tool schema to optionally include a server-side
timeoutMsand setask_user_questionto wait indefinitely (null) while the user is interacting. - Adjusted some UI wiring (overlay/tools menu) and made
useValConfigtolerate missing provider contexts (e.g. Storybook).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/spa/utils/toolNames.ts | Adds ask_user_question to the tool-name union for type-safe UI/tool mappings. |
| packages/ui/spa/hooks/useAIWebSocket.ts | Extends the AITool schema with optional timeoutMs for server-side waiting behavior. |
| packages/ui/spa/hooks/useAI.ts | Registers the new tool, routes tool calls to the UI question card, and adds answer/cancel APIs. |
| packages/ui/spa/components/ValOverlay.tsx | Wires the new answer/cancel handlers from useAI into AIChat. |
| packages/ui/spa/components/ToolsMenu.tsx | Wires the new answer/cancel handlers into AIChat for the tools menu variant. |
| packages/ui/spa/components/AIChat.tsx | Implements the question card UI, stores answers/cancel state, and updates tool activity rendering. |
| packages/ui/spa/components/AIChat.stories.tsx | Adds Storybook demos for pending/answered/cancelled question flows. |
| packages/ui/spa/components/ValFieldProvider.tsx | Makes useValConfig() resilient when rendered without ValFieldProvider. |
| packages/next/src/client/initValClient.ts | Adds debug logging in useValStega suspense gating (should be removed). |
| examples/next/val.config.ts | Enables experimental AI chat in the example config for demoing the feature. |
| examples/next/app/blogs/[blog]/page.tsx | Switches the blog example page to client/hooks usage but includes debug logs + now-unused imports. |
Comments suppressed due to low confidence (1)
packages/next/src/client/initValClient.ts:53
- Remove debug logging from the suspense gate; logging moduleIds during render can be noisy and expose internal module structure.
console.log("suspending", moduleIds);
| return; | ||
| }, | ||
| ); | ||
| console.log("->", valOverlayContext.enabled, store?.hasAllLoaded(moduleIds)); |
| "use server"; | ||
| "use client"; | ||
| import { notFound } from "next/navigation"; | ||
| import { fetchVal, fetchValRoute } from "../../../val/rsc"; |
Comment on lines
+15
to
21
| console.log("here"); | ||
| const blog = useValRoute(blogsVal, params); | ||
| const authors = useVal(authorsVal); | ||
| if (!blog) { | ||
| console.log("not found"); | ||
| return notFound(); | ||
| } |
Comment on lines
+1500
to
+1504
| // Reject any pending ask_user_question tool calls so the server-side | ||
| // conversation doesn't keep a dangling tool call open. | ||
| for (const toolCallId of pendingQuestionToolCallIdsRef.current) { | ||
| sendWsMessage({ | ||
| type: "ai_tool_result", |
Comment on lines
+1557
to
+1562
| <button | ||
| key={oi} | ||
| type="button" | ||
| disabled={submitted} | ||
| onClick={() => toggleOption(qi, oi, multiSelect)} | ||
| className={cn( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.