Fix double bounds in MinMax causing unsatisfiable constraints and false SAFE results#35
Open
shawshank-202 wants to merge 1 commit intovaibhavbsharma:svcompfrom
Open
Conversation
Author
|
Hey @sohah @vaibhavbsharma can you have a look at this and kindly give your feedback, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
This PR corrects the bounds for symbolic double variables in
MinMax, which resulted in an invalid range and unsound constraint generation.Problem
Symbolic double bounds were defined as:
However,
Double.MIN_VALUEis the smallest positive value (~4.9e-324), not the most negative value.This excludes all negative values from the domain.
float-nonlinear-calculation/Optimization2, JPF generates constraints like:This leads to:
All explored path conditions become unsatisfiable:
Result Before Fix
No paths are explored, leading to an incorrect SAFE verdict.
Results can be verified against
float-nonlinear-calculation/Optimization2
float-nonlinear-calculation/Optimization5
float-nonlinear-calculation/Optimization6
float-nonlinear-calculation/coral81
float-nonlinear-calculation/coral84