Spawn the current Node executable in PTY tests - #1010
Merged
sindresorhus merged 1 commit intoSep 20, 2026
Merged
sindresorhus merged 1 commit into
sindresorhus merged 1 commit into
Conversation
node-pty on Windows does not resolve 'node' through PATH, so every PTY-based test failed with 'File not found'. Use process.execPath, which also makes the tests run the same Node that started them on other platforms. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows every test that starts a fixture through
node-ptyfails before the fixture runs:node-ptyon Windows does not look the command up onPATH, sospawn('node', ...)cannot find the executable. This changes the fivespawn('node', ...)calls in the tests (helpers/run.ts,helpers/term.ts,exit.tsx,render.tsx,issue-973-static-commit.tsx) toprocess.execPath. On other platforms that is the same Node that is running the tests, rather than whichevernodehappens to be first onPATH.Windows 11, Node 24.13.1,
npx ava(default concurrency), before vs after: 163 failing tests -> 46. The remaining failures are not this problem: they compare exact escape sequences and line counts that ConPTY rewrites, or hit timeouts under load, so I left them alone. Linux behaviour is unchanged;xopasses on the touched files.Drafted with AI assistance (Claude Code); I ran the suite before and after and read the failures myself.