Use charger mah value to determine if charging animation should be pulsing#106
Open
gb0101010101 wants to merge 4 commits into
Open
Use charger mah value to determine if charging animation should be pulsing#106gb0101010101 wants to merge 4 commits into
gb0101010101 wants to merge 4 commits into
Conversation
Change charging indicator to use charger_mah so that animation is not always flashing when vacuum is docked but not charging.
Change charging indicator to use charger_mah so that animation is not always flashing when vacuum is docked but not charging.
|
Mine cycles on and off hourly when on the dock already |
Member
|
Mine also turns on/off depending on how its charging |
Author
|
Huh, that is interesting. I have D4 and D7 and both show that 
Here is the output of GetCharger command being sent to the D4: And GetVersion command: |
Member
|
That is very weird, I mean in that case, charging mAh should be used so that it works for as many as possible. Making a small patch today or tomorrow with some things, will include this one with that in that case |
Author
|
Just to add more info:
BTW love the new name; Futurama reference right? Very apt. |
Member
|
Very interesting, this is how fuel % looks for me and from little I have seen, most other people. The spikes are very interesting, I wonder what makes the robot report that, you are on the same version as me and most others, so find this weird. While it should have no difference since that did not change, could you try the latest 1.2 version? Its also more nice since it has some other improvements. Yes, the name is a Futurama reference, a user in the discord, mikeyp, came up with it and made the logo, I really liked it so adopted it fully. |
|
Regarding the charging behaviour, the BMS is in the battery I'm still using OEM in mine if you are too, Philip the differences in charging behaviour may be related to it. |
…rger_mah is not available or 0 Added check to make sure animation does not trigger when charger_mah is not available.
…rger_mah is not available or 0 Added check to make sure animation does not trigger when charger_mah is not available.
Author
|
I updated to v1.2 and everything is still the same with 
Also added check to make sure animation does not trigger when charger_mah is not available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the charging animation on the HA Card will always be pulsing, even when the battery is 100%, because
binary_sensor.<vacuum_name>_charging_activeis alwaysonwhen the vacuum is docked and has power from base station.IMHO the UI should not have animations if nothing is actually happening. The code already provides
sensor.<vacuum_name>_charger_mahvalue which is a much better basis to determine if the charging animation should be pulsing.This changes the animation to not pulsing when
sensor.<vacuum_name>_charger_mahis0.0