Skip to content

llm-proxy: the startup line drops user and password from the upstream URL - #995

Closed
vaaraio wants to merge 3 commits into
mainfrom
fix/proxy-upstream-userinfo
Closed

vaaraio wants to merge 3 commits into
mainfrom
fix/proxy-upstream-userinfo

Conversation

@vaaraio

@vaaraio vaaraio commented Oct 18, 2026

Copy link
Copy Markdown
Owner

The llm-proxy startup line printed the upstream URL as given, so a URL carrying a user and password (https://user:pass@gateway/v1) put the password on stderr and in any log that collects it. The line now prints the URL with the user and password removed. Tests cover a URL with credentials, a password containing @, and a plain URL.

Closes CodeQL alert 321.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 58df400a-35d4-4860-be14-f20771a0109d
📥 Commits

Reviewing files that changed from the base of the PR and between be3784d and cd36dd5.

📒 Files selected for processing: 2
  • src/vaara/integrations/llm_proxy.py
  • tests/test_llm_proxy_upstream_userinfo.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vaaraio
vaaraio enabled auto-merge (squash) October 18, 2026 16:45
@vaaraio vaaraio closed this Oct 18, 2026
auto-merge was automatically disabled October 18, 2026 17:19

Pull request was closed

@vaaraio
vaaraio deleted the fix/proxy-upstream-userinfo branch October 18, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant