Repository navigation
llm-proxy: an upstream error reaches the caller as its type only - #994
Merged
Merged
Conversation
A failed upstream connection returned the httpx error text to the agent, which can name internal hosts and ports. The reply now says "upstream unreachable: <ErrorType>"; the operator's log keeps the full text. The startup line also prints the upstream with any user:password replaced by ***. Closes CodeQL 321, 344, 357.
vaaraio
enabled auto-merge (squash)
October 18, 2026 15:28
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the upstream connection failed, the proxy returned the httpx error text to the caller. That text can name internal hosts and ports. The reply is now
upstream unreachable: <ErrorType>for both the chat path and the pass-through path, and the operator's log line keeps the full message.The startup line prints the upstream URL with any
user:password@replaced by***@.Tests: a connection error to an internal address returns only the type, and the printed upstream hides userinfo. Closes CodeQL 321, 344 and 357.