Skip to content

refactor: deprecate $ and $view in favor of find and findInView #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshabarov merged 1 commit into from
Jun 12, 2026
Merged

refactor: deprecate $ and $view in favor of find and findInView #2261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...stbench-unit-junit5/src/test/java/com/vaadin/flow/component/grid/BasicGridTesterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ void getCellComponent_columnByKey_canClickAButton() {
Assertions.assertInstanceOf(Button.class, cellComponent);
var button = (Button) cellComponent;
test(button).click();
var notification = $(Notification.class).last();
var notification = find(Notification.class).last();
Assertions.assertEquals("Clicked!", test(notification).getText());
}

Expand Down
8 changes: 4 additions & 4 deletions ...tbench-unit-junit5/src/test/java/com/vaadin/flow/component/login/LoginFormTesterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ void init() {
@Test
void login_generatesLoginEvent() {
test(view.login).login("user", "pwd");
Assertions.assertEquals(1, $(Span.class).from(view).all().size());
Span message = $(Span.class).from(view).withId("m1").first();
Assertions.assertEquals(1, find(Span.class).from(view).all().size());
Span message = find(Span.class).from(view).withId("m1").first();
Assertions.assertEquals(view.generateLoginMessage("user", "pwd"),
message.getText());
}
Expand All @@ -54,8 +54,8 @@ void login_disablesLoginComponent() {
void forgotPassword_generatesEvent() {
test(view.login).forgotPassword();

Assertions.assertEquals(1, $(Span.class).from(view).all().size());
Span message = $(Span.class).from(view).withId("m1").first();
Assertions.assertEquals(1, find(Span.class).from(view).all().size());
Span message = find(Span.class).from(view).withId("m1").first();
Assertions.assertEquals("forgot", message.getText());
}

Expand Down
8 changes: 4 additions & 4 deletions ...nch-unit-junit5/src/test/java/com/vaadin/flow/component/login/LoginOverlayTesterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ void login_generatesLoginEvent() {
login_.openOverlay();

login_.login("user", "pwd");
Assertions.assertEquals(1, $(Span.class).from(view).all().size());
Span message = $(Span.class).from(view).withId("m1").first();
Assertions.assertEquals(1, find(Span.class).from(view).all().size());
Span message = find(Span.class).from(view).withId("m1").first();
Assertions.assertEquals(view.generateLoginMessage("user", "pwd"),
message.getText());
}
Expand All @@ -66,8 +66,8 @@ void forgotPassword_generatesEvent() {
login_.openOverlay();
login_.forgotPassword();

Assertions.assertEquals(1, $(Span.class).from(view).all().size());
Span message = $(Span.class).from(view).withId("m1").first();
Assertions.assertEquals(1, find(Span.class).from(view).all().size());
Span message = find(Span.class).from(view).withId("m1").first();
Assertions.assertEquals("forgot", message.getText());
}

Expand Down
Loading
Loading