Replace pull_request_target with pull_request in CI workflow#2252
Merged
Conversation
Switch from pull_request_target to pull_request. Removes the check-permissions gate (no longer needed since fork PRs do not have access to secrets with pull_request). Test jobs skip entirely for fork PRs. Reviewers must validate fork PRs manually by checking out the branch.
mcollovati
approved these changes
May 21, 2026
Test Results 190 files 190 suites 54m 16s ⏱️ Results for commit bcbd230. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
pull_request_targetwithpull_requestinvalidation.yml.Removes the
check-permissionsjob (and its dependency onactions-cool/check-user-permission@main) which was the only gate preventing fork PRs from accessing secrets. Withpull_request, fork PRs do not have access to repository secrets at all, so the gate is no longer needed.Test jobs (
unit-tests,integration-tests,loadtest-converter-tests) andvalidation-statusskip entirely for fork PRs. Format check and build run for all PRs. Reviewers must validate fork PRs manually by checking out the branch.