Repository navigation
CI: Added python versions check - #105
Merged
Merged
Conversation
KClaudius
force-pushed
the
ckuehn/ci-test-readme-installation
branch
from
June 22, 2026 12:40
fa086dc to
fb24d69
Compare
KClaudius
force-pushed
the
ckuehn/ci-test-readme-installation
branch
2 times, most recently
from
June 22, 2026 12:45
d82747a to
18abce0
Compare
KClaudius
force-pushed
the
ckuehn/ci-test-readme-installation
branch
5 times, most recently
from
June 22, 2026 13:07
c9cc869 to
b4c6411
Compare
andizimmerer
approved these changes
Jun 23, 2026
andizimmerer
left a comment
Collaborator
There was a problem hiding this comment.
General note on limitations in GitHub actions:
- Using a matrix is cool and convenient. great.
- GitHub does not allow individual "success badges" per matrix - only on job level.
- Hence, the current workflow will allow you to only show a single badge in the README basically saying "yeah some python versions are supported - go figure it out yourself".
- This is fine, but then at least make it very explicit in the README.
- What I personally would prefer, even though this results in duplicate code: copy the workflow into 3 different files, each handling exactly one python version. Then we can have a badge for every supported Python version with the version in the name of the badge. I think this is much more readable and clearer; and I personally would sacrifice code-duplication for having this. But it's your call on how you want to do that. Both has advantages.
| @@ -0,0 +1,37 @@ | |||
| name: Python installation check | |||
Collaborator
There was a problem hiding this comment.
I would rather call it "Python Version Check"
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] |
Collaborator
There was a problem hiding this comment.
let's add
workflow_dispatch:
here as well. This allows triggering the run explicitly from the GitHub UI. Might be useful here (for formatting probably not so much)
| pull_request: | ||
| push: | ||
| branches: [main] | ||
|
|
Collaborator
There was a problem hiding this comment.
let's also add something like
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}
cancel-in-progress: ${{ !contains(github.ref, 'main')}}
This cancels workflow runs on subsequent pushes (except on main). I useful for expensive jobs. I guess it's not super expensive, but then you also learn how to do that ;)
|
|
||
| # SemCEB | ||
|
|
||
| **A Cardinality Estimation Benchmark for Semantic Operators** |
Collaborator
There was a problem hiding this comment.
please add a note that exactly these three versions are supported.
KClaudius
force-pushed
the
ckuehn/ci-test-readme-installation
branch
from
June 25, 2026 18:15
b714ef4 to
7be0357
Compare
KClaudius
force-pushed
the
ckuehn/ci-test-readme-installation
branch
from
June 25, 2026 18:27
596eadc to
195d8e1
Compare
KClaudius
force-pushed
the
ckuehn/ci-test-readme-installation
branch
from
June 25, 2026 18:36
602ebf2 to
1353036
Compare
KClaudius
added a commit
that referenced
this pull request
Jun 25, 2026
KClaudius
added a commit
that referenced
this pull request
Jun 25, 2026
KClaudius
added a commit
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.