Skip to content

CI: Added python versions check - #105

Merged
KClaudius merged 4 commits into
mainfrom
ckuehn/ci-test-readme-installation
Jun 25, 2026
Merged

KClaudius merged 4 commits into
mainfrom
ckuehn/ci-test-readme-installation

Conversation

@KClaudius

Copy link
Copy Markdown
Collaborator

No description provided.

@KClaudius
KClaudius force-pushed the ckuehn/ci-test-readme-installation branch from fa086dc to fb24d69 Compare June 22, 2026 12:40
@KClaudius
KClaudius force-pushed the ckuehn/ci-test-readme-installation branch 2 times, most recently from d82747a to 18abce0 Compare June 22, 2026 12:45
@KClaudius KClaudius changed the title CI: Added installation check CI: Added python installation check Jun 22, 2026
@KClaudius
KClaudius force-pushed the ckuehn/ci-test-readme-installation branch 5 times, most recently from c9cc869 to b4c6411 Compare June 22, 2026 13:07
@KClaudius
KClaudius requested a review from andizimmerer June 22, 2026 13:08

@andizimmerer andizimmerer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note on limitations in GitHub actions:

  • Using a matrix is cool and convenient. great.
  • GitHub does not allow individual "success badges" per matrix - only on job level.
  • Hence, the current workflow will allow you to only show a single badge in the README basically saying "yeah some python versions are supported - go figure it out yourself".
  • This is fine, but then at least make it very explicit in the README.
  • What I personally would prefer, even though this results in duplicate code: copy the workflow into 3 different files, each handling exactly one python version. Then we can have a badge for every supported Python version with the version in the name of the badge. I think this is much more readable and clearer; and I personally would sacrifice code-duplication for having this. But it's your call on how you want to do that. Both has advantages.

Comment thread .github/workflows/python-install.yml Outdated
@@ -0,0 +1,37 @@
name: Python installation check

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather call it "Python Version Check"

on:
pull_request:
push:
branches: [main]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add

  workflow_dispatch:

here as well. This allows triggering the run explicitly from the GitHub UI. Might be useful here (for formatting probably not so much)

pull_request:
push:
branches: [main]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add something like

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}
  cancel-in-progress: ${{ !contains(github.ref, 'main')}}

This cancels workflow runs on subsequent pushes (except on main). I useful for expensive jobs. I guess it's not super expensive, but then you also learn how to do that ;)

Comment thread README.md Outdated

# SemCEB

**A Cardinality Estimation Benchmark for Semantic Operators**

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a note that exactly these three versions are supported.

@KClaudius
KClaudius force-pushed the ckuehn/ci-test-readme-installation branch from b714ef4 to 7be0357 Compare June 25, 2026 18:15
@KClaudius KClaudius changed the title CI: Added python installation check CI: Added python versions check Jun 25, 2026
@KClaudius
KClaudius force-pushed the ckuehn/ci-test-readme-installation branch from 596eadc to 195d8e1 Compare June 25, 2026 18:27
@KClaudius
KClaudius force-pushed the ckuehn/ci-test-readme-installation branch from 602ebf2 to 1353036 Compare June 25, 2026 18:36
@KClaudius
KClaudius merged commit 553d554 into main Jun 25, 2026
10 checks passed
@KClaudius
KClaudius deleted the ckuehn/ci-test-readme-installation branch June 25, 2026 18:42
KClaudius added a commit that referenced this pull request Jun 25, 2026
KClaudius added a commit that referenced this pull request Jun 25, 2026
KClaudius added a commit that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants