test: add parser and contract coverage for plugin domain-finder#687
Open
anshul23102 wants to merge 7 commits into
Open
test: add parser and contract coverage for plugin domain-finder#687anshul23102 wants to merge 7 commits into
anshul23102 wants to merge 7 commits into
Conversation
- Add metadata validation tests for katana plugin - Add command rendering tests via PluginManager - Add parser contract tests with realistic fixtures - Verify plugin loads correctly through plugin system - Ensure parser handles severity classification - Validate empty output and raw line preservation Closes utksh1#501
- Add metadata validation tests for iac_scanner plugin - Add command rendering tests via PluginManager - Add parser contract tests with realistic fixtures - Verify plugin loads correctly through plugin system - Ensure parser handles severity classification (info/low/high) - Validate empty output and raw line preservation Closes utksh1#500
- Add metadata validation tests for http_request_logger plugin - Add command rendering tests via PluginManager - Add parser contract tests with realistic fixtures - Verify plugin loads correctly through plugin system - Ensure parser handles severity classification (info/low/high) - Validate empty output and raw line preservation Closes utksh1#499
- Add metadata validation tests for domain-finder plugin - Add command rendering tests via PluginManager - Add parser contract tests with realistic fixtures - Verify plugin loads correctly through plugin system - Ensure parser handles severity classification - Validate empty output and raw line preservation Closes utksh1#496
Contributor
Author
Label RequestThis PR addresses issue #496, adding comprehensive test coverage for the domain-finder plugin. This is a high-value testing contribution for GSSoC 2026. Could you please add the following labels when reviewed:
Thank you! |
…ory name) Domain-finder directory has a hyphen in its name, which Python's standard import system cannot handle. Use importlib.util to load the parser module directly from the file path instead.
utksh1
added
level:intermediate
utksh1
requested changes
Jun 8, 2026
utksh1
left a comment
utksh1
left a comment
Owner
There was a problem hiding this comment.
After #684 and #685 were merged, this stacked branch now conflicts with current main and still includes already-merged plugin-test files. Please rebase on main and keep only the domain-finder parser/contract coverage in this PR; remove katana/iac/http_request_logger changes that belong to earlier PRs. I can re-review after the effective diff is focused and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive test coverage for the domain-finder plugin, validating metadata, command rendering, and parser functionality.
Issue
Closes #496 - Plugin domain-finder appears in the shipped catalog but lacks direct test coverage.
Scope
This PR adds test coverage for:
pytest testing/backend -qTests Added (22 tests total)
Metadata Contract Tests:
test_domain_finder_metadata_file_existstest_domain_finder_metadata_is_valid_jsontest_domain_finder_passes_validatortest_domain_finder_metadata_id_matches_directorytest_domain_finder_engine_is_amasstest_domain_finder_has_required_target_fieldtest_domain_finder_output_parser_is_customtest_domain_finder_parser_file_existsCommand Rendering Tests:
test_domain_finder_command_renders_with_targettest_domain_finder_command_full_token_sequencetest_domain_finder_loaded_by_plugin_managerParser Contract Tests:
test_domain_finder_parser_returns_required_keystest_domain_finder_parser_count_matches_findingstest_domain_finder_parser_finding_has_required_keystest_domain_finder_parser_severity_classificationtest_domain_finder_parser_empty_outputtest_domain_finder_parser_preserves_raw_line_in_metadataType of Change
Related Issues
Closes #496
This contribution is part of GSSoC 2026.