ci: add Node.js runtime matrix coverage#672
Conversation
|
The Node.js matrix jobs completed successfully, but the required This appears to be due to branch protection expecting a single Would you prefer:
|
utksh1
left a comment
There was a problem hiding this comment.
This overlaps heavily with #673 for the backend test split, and the README addition currently duplicates the Runtime Support heading. Please rebase on latest main, remove the duplicated backend split if #673 lands first, and keep this PR focused on the Node runtime matrix plus a single clean README runtime-support note.
581863a to
630b6fb
Compare
|
Rebased and addressed the review feedback. Removed the backend test split changes so this PR is focused only on Node.js runtime matrix coverage. Also consolidated the README runtime support documentation and updated the workflow to validate Node.js 20 and 22. |
|
Addressed the requested changes.
All checks are now passing, including the Node.js matrix jobs. |
utksh1
left a comment
There was a problem hiding this comment.
Re-reviewed the latest push. The workflow YAML matrix indentation is still off and the README runtime-support section is inserted awkwardly under Prerequisites. Please fix YAML formatting, keep docs placement clean, preserve final newlines, and rerun CI.
5212ea9 to
fc68993
Compare
|
Thanks for catching that. I've cleaned up the workflow changes, and force-pushed the updated commit. Could you please re-review the latest commit when you have a chance? Thanks. |
utksh1
left a comment
There was a problem hiding this comment.
Re-reviewed the latest commit. This still needs changes before merge.
The README change inserts the Runtime Support section inside the Mermaid architecture diagram, between PM --> PARSER[parser.py] and the execution-engine edges. That breaks the diagram and moves ## Prerequisites into the code block context.
Please move the runtime-support note to a normal README section outside the Mermaid block, keep the workflow YAML indentation clean, and preserve the final newline in .github/workflows/ci.yml.
Summary
Motivation
The project documentation states support for Node.js 20+. Previously, CI exercised only a single Node.js runtime version. This change adds coverage for multiple supported Node.js baselines so runtime support claims are backed by automation.
Changes
CI
Updated the
frontend-checksjob to use a Node.js version matrix:Documentation
Added a Runtime Support section describing the runtime baselines currently validated by CI.
Testing