test(settings): add coverage for save reset and export flows #560#665
Conversation
utksh1
left a comment
There was a problem hiding this comment.
This needs cleanup before merge. The test file now includes a UTF-8 BOM at the start of the import line, adds an it.skip export-flow test, and the added coverage is mostly duplicated by existing Settings tests instead of exercising the requested save/reset/export behavior end-to-end. Please remove the BOM, avoid committed skipped tests, and either make the export-flow test active or keep the PR to focused non-duplicated coverage.
|
Hey @utksh1 , made the requested changes: Issues fixed:
What's added:
Please review the changes and feel free to give feedback |
utksh1
left a comment
There was a problem hiding this comment.
Re-reviewed the latest push. Still needs cleanup: SettingsTheme.test.tsx contains a BOM at the import line, skipped export coverage was split but the files still have no final newline, and the tests need to match existing formatting/hygiene. Please remove encoding/no-newline churn and rerun frontend checks.
|
heyy @utksh1 ,if u want to squash all the commits into one . U can convey me. |
|
Fixed all issues raised in the review: Removed UTF-8 BOM from SettingsTheme.test.tsx and SettingsExport.test.tsx (both files now start cleanly with import) All 11 tests pass locally via npm test. |
utksh1
left a comment
There was a problem hiding this comment.
The latest update removes the BOM/no-final-newline/test-style issues and keeps the diff to focused Settings save/reset/export coverage. CI is green on the reviewed head; approved pending a fresh branch update.
Description
Added page-level test coverage for
Settings.tsx.Changes include:
Related Issues
Closes #560
Type of Change
How Has This Been Tested?
Ran Vitest test suite locally:
npm testVerified:
Checklist