first implementation of myers diff [1]#21
Open
utkarshkukreti wants to merge 9 commits intomasterfrom
Open
Conversation
|
Do you have any plans on how and when to move forward with this change? I am looking at what can be done to improve uutils' diff, and the huge allocation for the LCS table is the number 1 blocker to making it work with bigger files. You mentioned that you want to make this optional as it will have worse performance compared to the full LCS in some cases. Have you considered adding some optimizations and heuristics similar to those used by GNU diff to make it a good enough middle ground? Would you take patches for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1.