Skip to content

Place the frame thread on the prime cluster and keep spinners off it #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
utkarshdalal wants to merge 3 commits into from
Closed

Place the frame thread on the prime cluster and keep spinners off it #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d360efc
Place the frame thread on the prime cluster and keep spinners off it
Nov 8, 2026
78486c9
Fix the role-change check and keep the game process to Windows processes
Nov 8, 2026
20bb456
Give threads created by a placed game thread the game pin
Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/main/java/app/gamenative/PrefManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1977,4 +1977,9 @@ object PrefManager {
var sharedShaderCache: Boolean
get() = getPref(SHARED_SHADER_CACHE, true)
set(value) { setPref(SHARED_SHADER_CACHE, value) }

private val FRAME_THREAD_PLACEMENT = booleanPreferencesKey("frame_thread_placement")
var frameThreadPlacement: Boolean

@cubic-dev-ai cubic-dev-ai Bot Nov 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This adds the advertised preference but does not expose it in the app, so users have no way to disable frame-thread placement through frameThreadPlacement; add a performance-settings switch and persist its value through this property.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At app/src/main/java/app/gamenative/PrefManager.kt, line 1982:

<comment>This adds the advertised preference but does not expose it in the app, so users have no way to disable frame-thread placement through `frameThreadPlacement`; add a performance-settings switch and persist its value through this property.</comment>

<file context>
@@ -1977,4 +1977,9 @@ object PrefManager {
         set(value) { setPref(SHARED_SHADER_CACHE, value) }
+
+    private val FRAME_THREAD_PLACEMENT = booleanPreferencesKey("frame_thread_placement")
+    var frameThreadPlacement: Boolean
+        get() = getPref(FRAME_THREAD_PLACEMENT, true)
+        set(value) { setPref(FRAME_THREAD_PLACEMENT, value) }
</file context>

get() = getPref(FRAME_THREAD_PLACEMENT, true)
set(value) { setPref(FRAME_THREAD_PLACEMENT, value) }
}
Loading
Loading