Repository navigation
SurfaceFlinger renderer: RGBA_8888 scan-out slots under the daemon's layout rule - #2324
utkarshdalal wants to merge 1 commit into
Conversation
Open container, test graphics and pre-install steps run on X11 even when the container's display server is gamescope. They picked the container's stored display renderer, a field the Graphics tab only shows for X11 containers, so a gamescope container silently kept the last X11 container's choice. On a RedMagic Astra (Android 16, GLES render engine) that leftover was the SurfaceFlinger renderer with compat mode off, which hands BGRA_8888 window buffers to surfaceflinger and aborts it on every open-container launch. The stored renderer now only applies to X11 containers; a gamescope container's X11 sessions use the Vulkan renderer, as its game session does.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Resolve renderer for the session app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt |
Renderer selection now uses the container’s stored renderer for X11 containers and Vulkan otherwise. GL requires an X11 session and either VirGL or a resolved GL renderer. Non-GL Gamescope sessions use Vulkan. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- utkarshdalal/GameNative#2220: Defines the Gamescope and X11 versus non-X11 session split addressed by this renderer routing change.
- utkarshdalal/GameNative#2276: Addresses the same reported SurfaceFlinger abort through a different renderer-related mechanism.
Suggested reviewers: joshuatam
Merge Risk: 
cf7f0
-
No actionable merge-blocking issue was identified in the renderer-selection change.
Pre-merge checks: 
-
Check name Status Explanation Resolution Title check The title describes a SurfaceFlinger RGBA_8888 scan-out change, but the changeset updates renderer selection for X11 sessions in gamescope containers. Use a title that describes the actual renderer-selection change, such as "Use Vulkan for X11 sessions in gamescope containers". Description check The description follows the required template and provides detailed technical context, but it describes an RGBA_8888 SurfaceFlinger change that does not match the supplied changeset or PR objective ab… Replace the description with details about selecting Vulkan for X11 sessions in gamescope containers, including the affected session types, renderer-selection behavior, and validation results. -
Check name Status Explanation Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Full details: Description check
-
Explanation
The description follows the required template and provides detailed technical context, but it describes an RGBA_8888 SurfaceFlinger change that does not match the supplied changeset or PR objective about X11 renderer selection.
Resolution
Replace the description with details about selecting Vulkan for X11 sessions in gamescope containers, including the affected session types, renderer-selection behavior, and validation results.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
utkarshdalal
changed the title
|
Superseded: the intended fix is the RGBA_8888 scan-out slots for the SurfaceFlinger renderer, opened as a separate PR on branch surfaceflinger-renderer-rgba-scanout-slots. The renderer-selection change here was dropped. |
Superseded by #2325 (RGBA_8888 scan-out slots for the SurfaceFlinger renderer). The renderer-selection change proposed here was dropped.