Repository navigation
gamescope: payload 20261102.4, shim from gamenative-drm master - #2323
Conversation
…ster Payload 20261102.4 is 20261101.6 with only lib/libadrenotools_gamescope.so replaced by the shim built from gamenative-drm master 2bfe8b3 (#44 merged, plus #45: the X11 wrapper's Vulkan feature lift, served by the shim), sha256 814601e9. gamescope and Xwayland are unchanged. libgamenative_drm.so built from the same master is 9d361968, byte-identical to the daemon already here: the daemon sources have not changed since #44's head, so the file does not change.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update payload version app/src/main/java/app/gamenative/display/GamescopePayload.kt |
GamescopePayload.VERSION changes to 20261102.4. The archive name and readiness check use the updated version. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Feature
Possibly related PRs
- utkarshdalal/GameNative#2320: This PR also updates the Gamescope payload shim version.
Suggested reviewers: joshuatam
Merge Risk: 
Minimal · up to 2c394
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "gamescope: payload 20261102.4, shim from gamenative-drm master" names the main change: the gamescope payload is bumped to 20261102.4 and its shim is rebuilt from gamenative-drm master. The PR's changed file (GamescopePayload.VERSION) and the objectives match this. The title is specific, though somewhat long at 62 characters and 7 words, and it does not mention the Vulkan feature-lift behavior.
Full details: Description check
-
Explanation
The description follows the repository template in substance. It has a clear '## Description' section explaining the shim rebuild, the daemon byte-identity, build and test evidence, payload hashes, and test steps. The 'Type of Change' and 'Checklist' sections are filled in. The '## Recording' section is left as the template placeholder, and the checklist item for attaching a recording is unchecked. The author states device re-anchoring runs will be added later. The description is mostly complete, so the check passes, but the missing recording should be noted.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Description
This ships the gamescope shim built from gamenative-drm master now that GameNative/gamenative-drm#44 is merged, as payload
20261102.4. App master runs payload 20261102.3, whose shim was built from #44's branch head (5831f1e) before the merge.drm master (2bfe8b3) has one change beyond #44:
icd_shim/src/advertise.rs(new),lib.rs,placed.rs,proxy.rs,docs/04-gamenative-app.md).VkPhysicalDeviceFeaturesbits that the X11 path'slibvulkan_wrapper.solifts.vkCreateDeviceit masks them back to what the driver actually answers.textureCompressionBCis not lifted.What changes in this PR
GamescopePayload.VERSION=20261102.4.jniLibs/arm64-v8a/libgamenative_drm.sodoes not change. Built from drm master, the daemon is9d3619681d9d5e382f78f2953c98ba1eff645334df8b7af8e88bc166ea774828, byte-identical to the one already on master (5144ef9c…in the APK after stripping), because the daemon sources are unchanged since #44's head.Build (NDK 27.3, rustc 1.98.1, daemon and shim in one cargo invocation,
SOURCE_DATE_EPOCH= head commit time)rust:1-bookworm: gndrm-daemon 99 unit + 36 golden + 8 diag, gndrm-android, gndrm-uapi 19 + 2 ABI.cargo test -p adrenotools_gamescope --lib, 75 passed.cargo clippy --target aarch64-linux-android -p adrenotools_gamescope -p gndrm-android -p gndrm-daemon --all-targets -- -D warningsis clean.tools/check-exports.shpasses.Payload 20261102.4
gamescope-gamenative-20261102.4.tzst, 14303755 B, sha256b3b30389f635effb5909e71f09f1dd5e43e030df3b19fed729fdda69b2929ad9. It is uploaded and verified on both CDN hosts, including the members from the served copy. It is 20261101.6 with only the shim replaced; every other member is byte-identical. 20261102.3 stays on the CDN.lib/libadrenotools_gamescope.so814601e954cf0a1e61b5632264dc6608af4e38fac5236301bc6aca58927876982026110210062bfe8b3bin/gamescope(unchanged)65d024fcee6af1b1f81b2281cc5223ee07615daa05aa8d9ecebe865526f8df69bin/Xwayland(unchanged)4dded8566661423ee3c91490523d96240c85906bd00e0774adc912df9dd38698Device
The re-anchoring runs (Retroid Pocket 6, Odin 3) will be added to this PR when they are done.
Test steps
Gamescope payload 20261102.4 ready, andgn-vkshim: ICD loaded [shim 202611021006 2bfe8b3]in the game process.gn-vkshim: present mode: declared=fifo … cap=60 … feedback=on … discarded=0 fallback=0.gndrm-daemon: vsync: check … late=0.Device re-anchor (RP6, this APK + payload 20261102.4 via the CDN)
Payload re-downloaded on the first launch (
.payload.version20261102.4; members gamescope 65d024fc, Xwayland 4dded856, shim 814601e9;ICD loaded [shim 202611021006 2bfe8b3]). Screenshots unchanged against the .3 build; no new shim/daemon/gamescope log patterns; 0 panics.Recording
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Bumps the gamescope payload to
20261102.4, replacing the shim built from thegamenative-drm#44 branch head with one built from master once #44 merged. The shim now reports the same ten core Vulkan physical device features that the X11 wrapper lifts, masking them back to the driver's real answers atvkCreateDevice; drivers that report their own capabilities see no change. The daemon is byte-identical to the one already on master, so only the shim member changes in the payload.Written for commit 2c3945e. Summary will update on new commits.
Summary by CodeRabbit