Repository navigation
Gamescope payload 20261101.1: flip events at SurfaceFlinger latch, Xwayland finishes GPU work before presenting - #2311
utkarshdalal wants to merge 2 commits into
Conversation
…present, A56 releases replaced framebuffers one flip later
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update payload version app/src/main/java/app/gamenative/display/GamescopePayload.kt |
GamescopePayload.VERSION changes from 20261031.3 to 20261101.1. |
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Bug fix
Possibly related PRs
- utkarshdalal/GameNative#2298: This PR defines panel-latch timing changes related to the Gamescope payload's flip-stamping and Xwayland presentation fixes.
Suggested reviewers: joshuatam
Merge Risk: 
Minimal · up to 2f9af
-
No actionable merge-blocking risk is identified in this version-only change.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description follows the required structure and provides detailed change context, validation results, change type, and checklist status. It explicitly states that no recording is attached and leaves the recording and code-change discussion checklist items unchecked.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
Draft: the Xwayland implicit-sync change reduces but does not remove the GL tear (6 flagged tears / 25 s against 23 on the shipped build in the end-to-end test of this payload). The remaining cause is measured: the guest's MIT-SHM attach is refused by the container sysvshm library, so each frame reaches Xwayland as 15 PutImage bands and commits land between them. A sysvshm fix follows; the DXVK-path changes (daemon flip at latch + A56) are unaffected. |
|
Superseded by the payload 20261101.2 PR (same branch contents plus the Xwayland from GameNative/xserver#2, which fixes the GL tear this payload still had). Closing. |
Description
Points the app at payload
gamescope-gamenative-20261101.1.tzstand ships the gamenative-drm daemon that reports page flips at SurfaceFlinger's latch.Two tearing bugs under gamescope, both measured on the Retroid Pocket 6:
Payload uploaded 2026-11-01 to https://downloads.gamenative.app/gamescope-gamenative-20261101.1.tzst, re-downloaded and verified: sha256
d4e674a5af358a0baae95a24be74154c240892cfbc03a90203918f31400d4997, 14292391 bytes. It is the shipped 20261031.3 with two members replaced (1014 members):bin/gamescopea56-release-one-flip-later@ 68241ca (A56), CI run 41304925663, md56c4d06a5c6060046ec93b571f63ed399bin/Xwaylandxwayland-no-implicit-sync-gamenative@ d486914 built by the same run, md56d117df905d008162d75c52f9cc2d379(linkslibxcvt.solike the shipped one)jniLibs/arm64-v8a/libgamenative_drm.soscanout-flip-at-latch@ 6aded49, md5e90fbdff817cc8307ceabd402118e23dNot changed: the shim (
lib/libadrenotools_gamescope.so), the FPS limiter, the cursor plane.Recording
None attached; recordings and tear analysis under the RP6 test logs (swd2-tearing-20261101).
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Points the app at gamescope payload
20261101.1to fix two tearing bugs on the Retroid Pocket 6. The gamenative-drm daemon now sends the page-flip event when SurfaceFlinger latches the frame instead of at apply time, sogamescopereleases replaced framebuffers one flip later;Xwaylandfinishes its GPU work before each present instead of assuming implicit sync.Verification
gamescope,Xwayland, andlibgamenative_drm.soreplaced; verified by sha256d4e674a5af358a0baae95a24be74154c240892cfbc03a90203918f31400d4997.swd2-tearing-20261101).Written for commit 2f9aff5. Summary will update on new commits.
Summary by CodeRabbit
20261101.1.