Repository navigation
Gamescope payload 20261029.1: glamor Mesa from upstream 26.2.6, no Xwayland fd leak on kernels before 6.0 - #2273
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update payload version app/src/main/java/app/gamenative/display/GamescopePayload.kt |
GamescopePayload.VERSION changes from 20261028.4 to 20261029.1. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Bug fix
Possibly related PRs
- utkarshdalal/GameNative#2266: Publishes payload version
20261028.4, the prior version referenced by this update.
Suggested reviewers: joshuatam
Merge Risk: 
Minimal · up to 28b78
-
No actionable merge-blocking risk was identified in this version-only update.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description includes all required sections, explains the change and validation results, identifies the change type, and completes the checklist. It explicitly notes that no recording is available, but this is a non-critical omission because the fix has no visible output change.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Description
Under gamescope, Xwayland composites with glamor on zink. The payload's glamor Mesa came from a local build of a 25.0-devel fork that no CI built. Its zink leaks one fd per composited frame on kernels older than 6.0 (the
DMA_BUF_IOCTL_EXPORT_SYNC_FILEfailure path returns without closing the fd). Xwayland reaches the fd limit and the game freezes. This froze Gravity Circuit on the Retroid Pocket Flip 2 (kernel 4.19), and it affects composited windows on any Adreno device with a kernel older than 6.0. Upstream Mesa 26.2.6 has the fix.GameNative/gamescope#17 builds the glamor Mesa in gamescope CI from the pinned upstream 26.2.6 tarball plus two patches (
android/mesa-glamor/).This PR:
GamescopePayload.VERSION20261028.4 -> 20261029.1.mesa-glamor-stageartifact of the gamescope CI run on the Update with cmod #17 head (run 40815961107; its tree 5c06a1b is identical to the merge commit 0cefd22):lib/libEGL_mesa.so.0,lib/libgbm.so.1,lib/libgbm.so,lib/gbm/dri_gbm.so,lib/dri/libdril_dri.so, andlib/libgallium-25.0.0-devel.so->lib/libgallium-26.2.6.so.lib/libglapi.so.0is removed (upstream folded glapi into libgallium).50_mesa.jsonand every other file,bin/gamescopeincluded, are unchanged.check-no-libandroid.sh: 76 ELFs, none NEEDs libandroid.so.check-payload-closure.sh: the only unresolved name islibnativewindow.so(a dlopen inlibadrenotools_gamescope.so), the same as in 20261028.4. All ELFs have 16 KB alignment.Xwayland fd count on the Galaxy Tab S7 (SM-T875, Android 11, kernel 4.19), wrapper test GL window held 150 s then two GDI windows held 150 s under gamescope:
The test payload was made the same way as 20261029.1, from the CI stage of #17 one commit before the head (that commit changed only
check-payload-closure.sh). The release payload 20261029.1 itself was not re-run on a device.Recording
None. The fix shows in the fd counts above; the visible output does not change.
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Replaces the payload's glamor Mesa with an upstream 26.2.6 build, fixing an Xwayland fd leak on kernels before 6.0. The old 25.0-devel fork's zink leaked one fd per composited frame, pushing Xwayland to the fd limit and freezing games such as Gravity Circuit on the Retroid Pocket Flip 2 (kernel 4.19). Upstream 26.2.6 contains the fix.
Bug Fixes
GamescopePayload.VERSIONto 20261029.1, whose glamor Mesa files come from the upstream 26.2.6 build in gamescope CI.Written for commit 28b7895. Summary will update on new commits.
Summary by CodeRabbit
20261028.4to20261029.1. This is a metadata update; no changes to user-facing features or app behavior are described in this release.