Skip to content

Gamescope payload 20261027.1: bring nested game windows to the front - #2263

Merged
utkarshdalal merged 1 commit into
masterfrom
gamescope-payload-20261027-1
Oct 27, 2026
Merged

utkarshdalal merged 1 commit into
masterfrom
gamescope-payload-20261027-1

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Description

Under gamescope, a game running inside wine's virtual desktop was never activated: no controller or keyboard input, XInput polled only once, and the window stayed hidden. NFS Most Wanted stayed stuck on PRESS START.

Gamescope A48 (GameNative/gamescope#16) now sends winhandler.exe the same bring-to-front request that the X11 server sends when a window is mapped. This PR bumps GamescopePayload.VERSION to 20261027.1 so the app fetches the new payload. Nothing else changes (the daemon in jniLibs is unchanged).

Payload: 20261026.3 with bin/gamescope and bin/gamescopereaper replaced by the build of gamescope master fa3f3fb (run https://github.com/GameNative/gamescope/actions/runs/40500586176).

Verified on the Odin 3 with the same repack of the PR build:

  • NFS Most Wanted: pad works, XInput polled at 60 Hz, title -> gameplay, 59.5 fps.
  • Hades II: pad navigation OK, clean exit.
  • Celeste: pad navigation OK, clean exit.
  • One A48 log line per session, no repeats, no helper or dialog windows brought forward, no crashes.

Recording

Not attached (payload bump only).

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by CodeRabbit

  • Maintenance
    • Updated the Gamescope payload version. The app will now check readiness and select the corresponding archive for the updated version.

Under gamescope, a game running inside wine's virtual desktop was never
activated. It got no controller or keyboard input, XInput was polled only
once, and the window stayed hidden behind the desktop. NFS Most Wanted
stayed stuck on PRESS START.

Gamescope A48 (GameNative/gamescope#16) now sends winhandler.exe the same
bring-to-front request that the X11 server sends when a window is mapped.

The payload is 20261026.3 with the gamescope and gamescopereaper binaries
from gamescope master fa3f3fb. Verified on the Odin 3 with NFS Most Wanted,
Hades II and Celeste.
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e303d7de-5bfe-4475-8707-9fd4cfee08a0
Commits

Reviewing files that changed from the base of the PR and between 02d111b and 38f3535.

Files selected for processing: 1
  • app/src/main/java/app/gamenative/display/GamescopePayload.kt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

GamescopePayload.VERSION changes to 20261027.1. The version-derived archive name and readiness check use this updated value.

Changes: Gamescope payload

Layer / File(s) Summary
Update payload version
app/src/main/java/app/gamenative/display/GamescopePayload.kt
GamescopePayload.VERSION changes from 20261026.3 to 20261027.1.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: joshuatam

Merge Risk: Minimal · up to 38f35

No actionable merge-blocking risk is identified in this version-only update.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title is concise, specific, and accurately identifies the Gamescope payload version and the bring-to-front fix for nested game windows.
Description check Passed The description is complete and relevant. It explains the bug, payload changes, verification results, checksum, and checklist status. The recording is not attached, but the omission is explicitly docu…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description is complete and relevant. It explains the bug, payload changes, verification results, checksum, and checklist status. The recording is not attached, but the omission is explicitly documented for this payload-only change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@utkarshdalal
utkarshdalal merged commit eaa715c into master Oct 27, 2026
4 checks passed
@utkarshdalal
utkarshdalal deleted the gamescope-payload-20261027-1 branch October 27, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant