Repository navigation
Use gamescope payload 20261023.4: shim thunks keyed by target, LSFG latch-grid pacing - #2233
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly identifies the payload version and the two main fixes included in that payload: target-keyed shim thunks and LSFG latch-grid pacing. |
| Description check | |
The description follows the required template. It explains the change and cause, provides recording details, selects the change type, and completes all checklist items. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…atch-grid pacing Payload 20261023.4 is 20261023.3 with the ICD shim built from gamenative-drm master e1f4474, and the bundled libgamenative_drm.so is the daemon from the same commit. Together they carry: - gamenative-drm#15: thunks keyed by target address. Dishonored DE (DXVK 1.10.3, D3D9) died at its first query reset under gamescope because the shim kept one thunk per function name per process: zink's device resolved vkResetQueryPoolEXT first through an Android loader trampoline valid for that device, and DXVK's 1.1 device then reused that thunk and jumped through an empty dispatch slot. The shim's diagnostics are now per device and uncapped. - gamenative-drm#14: LSFG generated frames are paced on the panel's latch grid, in order. The daemon sends vsync notes to a shim that subscribes with the new capability bit, so shim and daemon ship as a pair.
utkarshdalal
force-pushed
the
gamescope-payload-thunk-per-target
branch
from
October 23, 2026 13:59
2bb0499 to
e248ec7
Compare
utkarshdalal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Payload 20261023.4: 20261023.3 with the ICD shim built from gamenative-drm master e1f4474, and the bundled
libgamenative_drm.sois the daemon from the same commit. The pair carries GameNative/gamenative-drm#15 (thunks keyed by target) and #14 (LSFG frames paced on the panel's latch grid; the daemon sends vsync notes to a shim that subscribes with the new capability bit, so shim and daemon ship together). The archive is live on both CDN URLs.Dishonored DE (Epic, D3D9 through DXVK 1.10.3, Proton 11.0-2-x86_64-7, AYN Thor on Turnip) died ~11 s into a gamescope session at its first query reset:
vkResetQueryPoolEXT Exception 0xc0000005 in Unix call, a branch to PC 0. The game's process creates two Vulkan devices: zink's first (API 1.2+, no host-query-reset extension, so that name resolved through the alias to Android's exported corevkResetQueryPooltrampoline, valid for that device), then DXVK's (API 1.1, extension enabled, correct answer Turnip's own function). The shim kept one thunk per function name per process, so DXVK's device reused zink's thunk and jumped through an Android dispatch slot that is empty for a 1.1 device. The shim now keys thunks by target address, and its diagnostic logs are per device and uncapped (the old per-process caps had hidden the decisive line in two user logs).Recording
Odin 3 (Adreno 830, Turnip Gen8 V37, gamescope) with the #15 shim before #14 landed: Vampire Survivors (64-bit DXVK, two devices in one process) 60 fps, Blazing Chrome (32-bit) 60 fps, Balatro (zink) ~277 fps; splash hides within 20 ms of the first-map note; no exceptions; no thunk retargets. Not run on the Thor; BrainBeat's next log should show
thunk retarget vkResetQueryPoolEXTfollowed by a second thunk into libvulkan_freedreno.so.Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.