Skip to content

Avoid logging captured environment values - #1226

Draft
shunichironomura wants to merge 1 commit into
mainfrom
fix/1083-redact-env-debug-log
Draft

shunichironomura wants to merge 1 commit into
mainfrom
fix/1083-redact-env-debug-log

Conversation

@shunichironomura

Copy link
Copy Markdown
Member

Warning

This content was written by an AI agent and must be verified by a human developer. After human verification, this alert may be removed.

Summary

Raw values are still persisted in capture output. Redaction/hash-only capture mode is intentionally deferred.

AI assistance

  • AI used: yes — Amp investigated the issue, implemented the change, and ran verification
  • Human review of AI-assisted code: pending

Breaking changes

  • No breaking changes
  • Breaking changes; the breaking change label is applied

Verification

  • cargo test -p capsula-capture-env
  • cargo fmt --check --all
  • cargo clippy -p capsula-capture-env --all-targets --all-features -- -D warnings
  • end-to-end CLI run with debug logging, asserting the test secret was absent while the variable name and byte length were present

Amp-Thread-ID: https://ampcode.com/threads/T-01a06b7c-a80b-7749-8679-b34f7d63cb18
Co-authored-by: Shunichiro Nomura <shunichiro.nomura.1035@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.16%. Comparing base (433b438) to head (7d4ea91).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1226   +/-   ##
=======================================
  Coverage   54.16%   54.16%           
=======================================
  Files          44       44           
  Lines        4233     4233           
=======================================
  Hits         2293     2293           
  Misses       1940     1940           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants