Skip to content

Fix vault .gitignore creation for existing directories - #1222

Draft
shunichironomura wants to merge 2 commits into
mainfrom
fix/1072-vault-gitignore
Draft

shunichironomura wants to merge 2 commits into
mainfrom
fix/1072-vault-gitignore

Conversation

@shunichironomura

Copy link
Copy Markdown
Member

Warning

This content was written by an AI agent and must be verified by a human developer. After human verification, this alert may be removed.

Summary

  • ensure the vault directory exists without returning before .gitignore setup
  • atomically create .gitignore only when absent, preserving existing custom contents
  • add regression coverage for pre-existing vault directories and existing ignore files

Closes #1072.

AI assistance

  • AI used: yes — Amp investigated the issue, implemented the fix, and added tests
  • Human review of AI-assisted code: pending

Breaking changes

  • No breaking changes
  • Breaking changes; the breaking change label is applied

ampagent and others added 2 commits September 4, 2026 08:15
Amp-Thread-ID: https://ampcode.com/threads/T-01a06b79-6e3c-76dc-82ad-8cac11c39188
Co-authored-by: Shunichiro Nomura <shunichiro.nomura.1035@gmail.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a06b79-6e3c-76dc-82ad-8cac11c39188
Co-authored-by: Shunichiro Nomura <shunichiro.nomura.1035@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.42%. Comparing base (433b438) to head (f204887).

Files with missing lines Patch % Lines
crates/capsula-core/src/run.rs 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
+ Coverage   54.16%   54.42%   +0.25%     
==========================================
  Files          44       44              
  Lines        4233     4257      +24     
==========================================
+ Hits         2293     2317      +24     
  Misses       1940     1940              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vault .gitignore is skipped whenever the vault directory already exists (captured data can be committed)

3 participants