tui: remove visible error append for MCP failure/cancelled status#129
Merged
Conversation
MCP startup failures and cancellations are transient operational events.
Show them in the status bar and internal logs instead of injecting error
messages into the visible chat transcript.
- Remove m.append("error", ev.Text) from EventMCPStatus handler
- Rename and update TestMCPStatusFailureAddsVisibleWarning to
TestMCPStatusFailureUpdatesStatusAndLogOnly, verifying status
update + log entry + no transcript pollution
- Refactor TestLocalCommandResultCommitsIdleAssemblerBeforeNextPrompt
to use EventInfo instead of EventMCPStatus{failed}, since the test
was never about MCP failure behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP startup failures and cancellations are transient operational events. Show them in the status bar and internal logs instead of injecting error messages into the visible chat transcript.
Changes
m.append("error", ev.Text)fromEventMCPStatushandler for failed/cancelled statusesTestMCPStatusFailureAddsVisibleWarning→TestMCPStatusFailureUpdatesStatusAndLogOnlywith updated assertions (status + log entry, no transcript pollution)TestLocalCommandResultCommitsIdleAssemblerBeforeNextPromptto useEventInfoinstead ofEventMCPStatus{failed}— the test was always about idle-assembler commit ordering, not MCP failure behaviorTesting
make testpasses