feat(windows): expand %VAR% env vars in config paths, generalise temp dir check#127
Merged
Merged
Conversation
… dir check - Add expandWindowsPercentEnv to resolve %USERPROFILE%, %APPDATA%, etc. in config file path resolution on Windows. - Extract pathInsideTrustedTemp helper that uses os.TempDir() for cross-platform temp directory detection, replacing hardcoded /tmp/ and /private/tmp/ prefix checks. - Add build-tagged Windows tests for both changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-up improvements from the Windows compatibility pass (PR #120):
1. Windows environment variable expansion in config paths
Adds so paths like and are resolved at config-load time.
2. Cross-platform temp directory detection
Extracts from the inline / checks. The new helper uses — which returns the correct temp root on all platforms (e.g. on Windows) — and falls back to the Unix hardcoded paths for safety.
Testing