[bug] fix plugin reload and session meta patching#125
Merged
Conversation
dd40b74 to
c1cb750
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two state handling bugs in Whale:
ApplyLoadedConfigerrors from plugin disabled-config reloads instead of silently updating runtime plugin state from invalid configSessionMetaPatchsoTotalCostUSDandTurnCountcan be explicitly reset to zero without losing the existing partial-patch semanticsRoot Cause
reloadPluginDisabledConfigignored the error fromApplyLoadedConfig, unlike the skill reload path.PatchSessionMetaused numeric zero as the sentinel for "not provided", which made it impossible to patch cost or turn count back to zero.Validation
go test ./internal/session ./internal/appmake testgit diff --check./bin/whale:/pluginssurfaced invalidui.view_modeand/memoryremained available after the failed reload; a normal turn wrote session meta withturn_count: 1and cost