fix(tui): route Home/End to readline composer instead of transcript viewport#124
Merged
Conversation
…iewport Home and End were previously grouped with PgUp/PgDn as transcript-scroll keys (jumping to buffer top/bottom). After the readline alignment they should move the cursor to start/end of the current line within the composer — the same as Ctrl+A/Ctrl+E. - model_keys.go: remove 'home' and 'end' from the pgup/pgdown scroll case - composer_test.go: add TestComposerHomeAndEndMoveWithinCurrentLine - model_test.go: rename and update the scroll key test to assert that Home/End no longer affect the transcript viewport; update downstream tests to call handleViewportScrollKey directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home and End were previously grouped with PgUp/PgDn as transcript-scroll keys (jumping to buffer top/bottom). After the readline alignment they should move the cursor to start/end of the current line within the composer — the same as Ctrl+A/Ctrl+E.
Changes:
model_keys.go: removehomeandendfrom the pgup/pgdown scroll case in chat modecomposer_test.go: addTestComposerHomeAndEndMoveWithinCurrentLinemodel_test.go: rename/update scroll key test to assert Home/End no longer affect the transcript; update downstream tests to callhandleViewportScrollKeydirectlyTesting:
make testpasses (existing + new tests)