Prepares the removal of the final annotation (Tree@\loc), including its definition and all of its uses. #1974
Draft
jurgenvinju wants to merge 18 commits intomainfrom
Draft
Prepares the removal of the final annotation (Tree@\loc), including its definition and all of its uses. #1974jurgenvinju wants to merge 18 commits intomainfrom
jurgenvinju wants to merge 18 commits intomainfrom
Conversation
… _only_ work for Eclipse. We can upgrade Eclipse to also use util::IDEServices and util::LanguageServer, or we can drop them as soon as we drop Eclipse
Member
Author
|
The
It has to run on the entire project to make sense as the refactoring is "dumb"; it does not follow name resolution links it just replaces all syntactical constructs in a consistent manner. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
========================================
- Coverage 46% 46% -1%
+ Complexity 6737 6717 -20
========================================
Files 794 794
Lines 65923 65923
Branches 9888 9888
========================================
- Hits 30858 30747 -111
- Misses 32684 32795 +111
Partials 2381 2381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR implements the first step in a bootstrap cycle to replace Tree@\loc by loc Tree.src
lang::rascal::upgrade::UpgradeAnnotationsToKeywordParametersreportfrom this module first to see what the relevance and impact would beThis change impacts all projects with code that uses
Tree.\@loc; so that's a lot. The first of the typepal project on which the Compiler and the checker on the current project depend. Releasing a refactored version of typepal is the next step.This branch does not remove the old feature yet for two reasons:
Commits: