Complete self-hosted relay smoke path#1
Conversation
Manual OAuth code flow (LoginManager.poll) reads a code_exchange row keyed
by state.slice(0,15); nothing wrote it on self-host, so the manual/mobile
login flow hung for 30s and timed out.
- pb_hooks/oauth2_code_exchange.pb.js: global middleware on
GET /api/oauth2-redirect that upserts {id: state[:15], code} via DAO, then
calls next(c) so the built-in handler + popup/SSE flow stay intact.
(additive middleware, not routerAdd, to avoid conflicting with the
built-in route). v0.22 echo JS API.
- migration: code_exchange viewRule -> public. poll() runs pre-auth, so
view: AUTHED would forbid the anonymous getOne and time out login. The
15-char id is the high-entropy OAuth-state slice (capability); listRule
stays null to block enumeration; writes go via DAO (bypass API rules).
- README: documented the new hook and marked the gap resolved.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8bca0867c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "pocketbase migrate up --dir /pb/pb_data --migrationsDir /pb/pb_migrations && | ||
| pocketbase serve --http=0.0.0.0:8090 --dir /pb/pb_data | ||
| --migrationsDir /pb/pb_migrations --hooksDir /pb/pb_hooks" |
There was a problem hiding this comment.
With entrypoint: ["/bin/sh", "-c"], this folded block passes the leading and trailing double quotes literally into sh -c; the shell then treats everything between them as one command word, so && is not an operator and it tries to execute a command named pocketbase migrate up ... && pocketbase serve ..., exiting 127. In this compose workflow the PocketBase container never becomes healthy, so token-service remains blocked on depends_on; remove the wrapper quotes around the folded command.
Useful? React with 👍 / 👎.
|
Added the cheap single-VM deployment path in abbbf21:
Validated with: docker compose -f docker-compose.vm.yml --env-file .env.vm.example config |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abbbf2162c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "pocketbase migrate up --dir /pb/pb_data --migrationsDir /pb/pb_migrations && | ||
| pocketbase serve --http=0.0.0.0:8090 --dir /pb/pb_data | ||
| --migrationsDir /pb/pb_migrations --hooksDir /pb/pb_hooks" |
There was a problem hiding this comment.
When following docs/single-vm.md, this VM stack uses entrypoint: ["/bin/sh", "-c"], so the leading quote in the folded command is passed literally to sh -c; I verified /bin/sh -c '"echo hi && echo bye"' treats && as part of the command name and exits 127. PocketBase therefore never becomes healthy and the VM deployment remains blocked; drop the outer quotes around the folded command.
Useful? React with 👍 / 👎.
|
|
||
| routerAdd( | ||
| "POST", | ||
| "/api/self-host-rotate-key", |
There was a problem hiding this comment.
The Relay plugin path used for share-key rotation still posts to /api/rotate-key (patches/relay-plugin.patch only changes the build URLs and does not patch that call), but this hook registers only /api/self-host-rotate-key. In the Obsidian UI, rotating an invitation will therefore hit PocketBase's reserved/missing route instead of rotateInvitationKey, so the key will not rotate unless the plugin patch is updated or this hook also handles the original route.
Useful? React with 👍 / 👎.
| env_file: | ||
| - .env |
There was a problem hiding this comment.
On a fresh checkout following the README's docker compose up -d, .env is gitignored and never created for the local compose path, but this new env_file entry is required by default (Docker documents required: true as the default: https://docs.docker.com/compose/how-tos/environment-variables/set-environment-variables/#use-the-env_file-attribute). Because RELAY_SERVER_AUTH already has a ${...:-} fallback, this should be optional or the setup docs should create a local .env before starting the stack.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 800c0e625f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // can't produce a valid id and isn't something PB's own flow generates, so | ||
| // skip rather than write an invalid record. | ||
| if (state && code && state.length >= 15) { | ||
| const id = state.substring(0, 15); |
There was a problem hiding this comment.
When the manual OAuth redirect state contains uppercase characters, this uses the raw state.substring(0, 15) as a PocketBase record id; PocketBase's default record id validation is lowercase-only, while OAuth states commonly include [A-Za-z0-9]. In that case dao.saveRecord(rec) throws, the catch only logs it, and no code_exchange row is written for LoginManager.poll, so those logins time out. Use an ID-safe derivation that the client also polls, or adjust the collection/client contract to allow the generated state slice.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6391e506ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ["roleowner000000", "Owner"], | ||
| ["rolemember00000", "Member"], | ||
| ["rolereader00000", "Reader"], |
There was a problem hiding this comment.
The plugin starts with a local role map keyed by the production Owner/Member ids (2arnubkcv7jpce8 and x6lllh2qsf9lxk6) and resolves RelayRole.role/RelayInvitation.role by looking up the relation id in that map, while it does not fetch the roles collection directly. Seeding different ids here means the hooks create relay roles and invitations whose role names are unknown until some later expanded role happens to be ingested, so immediate owner/member policy checks and folder-role creation after registration can fail. Seed the plugin-compatible ids or explicitly fetch/expand all roles before these records are used.
Useful? React with 👍 / 👎.
| ```bash | ||
| cd ~/relay-self-hosted/relay-plugin | ||
| RELAY_API_URL=https://relay.example.com node esbuild.config.mjs | ||
| RELAY_API_URL=https://relay.example.com RELAY_AUTH_URL=https://auth.example.com node esbuild.config.mjs |
There was a problem hiding this comment.
For the single-VM layout added in this change, relay.example.com is proxied to the relay-server, but API_URL is the token-service host (api.example.com in the table above and in docs/single-vm.md). Following this rebuild command makes the plugin send /token and /file-token to relay-server instead of token-service, so token minting fails on remote deployments built from the README.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Remaining follow-up