Move the apply filter for jwt_auth_valid_credential_response#137
Open
chrisladams wants to merge 1 commit into
Open
Move the apply filter for jwt_auth_valid_credential_response#137chrisladams wants to merge 1 commit into
chrisladams wants to merge 1 commit into
Conversation
…er refesh token is generated so a user can add it to the json response
Collaborator
|
Hey, thanks for contributing your improvement! I'm concerned that this changes what is contained in the value that is passed to the filter hook callbacks. This would break existing sites that are using the filter already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the
apply_filters( 'jwt_auth_valid_credential_response')to below the refresh token generation so a user can append the json output with relevant data.