Conversation
- Added `createResponseBodyClient` for IPC communication to manage response bodies. - Introduced `useResponseBodyWindow` hook for sliding-window text management, optimizing memory usage for large file-backed responses. - Created utility functions for pinning and releasing response body references. - Implemented tests for new functionality, ensuring robust handling of response body operations. - Refactored existing code to remove deprecated IPC adapters and streamline response body management.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dispatch folder-run events before awaiting body pins so assertion results are not lost, align formatResponse tests with the bodyRef path, and use stable download testids that do not clash with collection names.
Runner was replacing 4xx/5xx axios responses with an IPC-shaped payload whose data was getDataForIpc(), so assertions like res.body.error failed on OAuth 401 cases.
Windows path.join turns /spill/body-1 into \spill\body-1; assert with path helpers instead of POSIX literals.
Response examples still read dataBuffer out of Redux, which this PR no longer stores, so binary save/preview e2e failed. Read raw bytes from the body store on save, and drop the download spec that only asserted a CSS-hidden toolbar button.
sid-bruno
force-pushed
the
wip/large-files-mod
branch
from
September 18, 2026 10:36
b2192a4 to
db9e294
Compare
Resolve RunnerResults import conflict by keeping pin-release reset helper and adding folder-tag effective tags helper.
…d pin logic - Updated `ClearTimeline` and `ResponseClear` components to use new action creators for clearing responses without pin management. - Introduced `useResponseBody` hook for handling response body loading, replacing direct state management in `QueryResult`. - Removed unused pin-related functions and cleaned up response body handling in Redux actions and IPC. - Enhanced error handling and loading states for response body retrieval. - Updated tests to reflect changes in response body handling and ensure proper functionality.
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TBD
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.