test(e2e): follow-ups for the theme switcher coverage

[arpit-bruno]

Ref BRU-4604

Follow-up to #86.

What changed

• Renamed the navigation test to "keeps the chosen theme while moving between Overview, Environments, and a request". The old name said "remembers", but the test never reloads: the app routes by hash, so moving between pages keeps the theme in memory. With theme saving disabled, it still passed. Persistence is already covered by the reload, new tab and explicit light tests, which all fail when saving is broken.
• Fixed the indentation of the tooltip test added in fix(docs): parity UI bugs 2, group 3 #89. It was already inside the "when the OS prefers light" block, but indented as if it were outside.
• Added an html locator to ThemeToggleComponent and used it in place of the 13 inline page.locator('html') calls. Dropped the page fixture from the tests that no longer need it.

Testing

• Spec passes locally, 3 runs with no flakes.
• Disabling theme saving (localStorage.setItem in store/slices/theme.ts) fails exactly the three persistence tests and each one fails for the reason its name gives.

[changeset-bot]

🦋 Changeset detected

Latest commit: c281dd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR