Repository navigation
Remove unused jQuery setup hooks - #159
Open
adamtheturtle wants to merge 1 commit into
Open
adamtheturtle wants to merge 1 commit into
adamtheturtle wants to merge 1 commit into
Conversation
jdillard
approved these changes
Oct 1, 2026
jdillard
left a comment
Contributor
There was a problem hiding this comment.
Nice find. I agree that both hooks are unregistered and unreferenced, so removing them and their imports preserves existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup_jqueryfunctions from the documentation and demo configurationsThese functions were never registered as Sphinx event handlers or called directly, so they could not inject jQuery. Removing the dead hooks eliminates the unnecessary reflective access to
html_js_fileswithout replacing it with another typing workaround.