Skip to content

Remove unused jQuery setup hooks - #159

Open
adamtheturtle wants to merge 1 commit into
useblocks:mainfrom
adamtheturtle:remove-unused-jquery-setup
Open

adamtheturtle wants to merge 1 commit into
useblocks:mainfrom
adamtheturtle:remove-unused-jquery-setup

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Sep 12, 2026 •

Copy link
Copy Markdown

Summary

  • remove the unused setup_jquery functions from the documentation and demo configurations
  • remove the now-unused Sphinx imports

These functions were never registered as Sphinx event handlers or called directly, so they could not inject jQuery. Removing the dead hooks eliminates the unnecessary reflective access to html_js_files without replacing it with another typing workaround.

@jdillard jdillard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. I agree that both hooks are unregistered and unreferenced, so removing them and their imports preserves existing behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants