Skip to content

fix: make the account id optional when getting plans - #1

Open
joshghent wants to merge 10 commits into
usebasejump:mainfrom
joshghent:fix/account-id-optional
Open

joshghent wants to merge 10 commits into
usebasejump:mainfrom
joshghent:fix/account-id-optional

Conversation

@joshghent

Copy link
Copy Markdown

This means that a user doesn't need to be logged in to view plans.
The docs for this endpoint describe the account_id being optional but sending null or not providing this argument causes an error to be thrown. https://usebasejump.com/docs/billing#get-plans

@joshghent

Copy link
Copy Markdown
Author

Apologies, i've added a load of testing commits to this! Will fix this :)

@jfloodnet

Copy link
Copy Markdown

Hi @joshghent - how are you currently packaging your fork? Would be good to get my hands on this while we wait for the merge. Cheers

@joshghent

Copy link
Copy Markdown
Author

@jfloodnet update the import for this repo in billing-functions/index.ts and billing-webhooks/index.ts like this

before

import {
    billingEndpoint,
    stripeBillingEndpoint
} from "https://deno.land/x/basejump@v2.0.3/billing-functions/mod.ts";

after

import {
  billingWebhooksWrapper,
  stripeWebhookHandler,
} from "https://raw.githubusercontent.com/joshghent/basejump-deno-packages/fix/account-id-optional/billing-functions/mod.ts";

Then just deploy the functions again with supabase deploy.

@jfloodnet

Copy link
Copy Markdown

thanks @joshghent will give a go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants