Repository navigation
Add tests for the integrations API client - #433
Open
Shahmeerdv wants to merge 1 commit into
Open
Shahmeerdv wants to merge 1 commit into
Shahmeerdv wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271.
Adds
frontend/app/(workspace)/settings/integrations-api.test.ts, covering every exported function inintegrations-api.ts. It stubsfetchandwindowthe same waylib/create-run.test.tsdoes, sobackendFetchtakes its browser path.fetchIntegrations: reads/api/integrationswithcache: "no-store"and decodes the list; throws on a non-OK responsestartIntegrationConnect: GitHub and Slack use the/orgpath while other apps don't; the provider is URL-encoded; posts thereturnTobody; returnsexpiresAt: nullwhen the backend omits it; throws on a non-OK response; throws whenredirectUrlorstateis missing or blankcompleteIntegrationConnect: posts the state and callback, and leavescallbackout when there is none; returnsnullon 400 and 409; throws on other errors; throws when the answer has no usable connectiondisconnectIntegration: DELETE on the/orgpath for GitHub and Slack and the user path otherwise, with the connection id encoded; throws on a non-OK responseNo source changes.
Checks
To check the tests catch real regressions, I temporarily changed the source so Slack skipped the
/orgpath and 409 stopped counting as pending: 3 tests failed (the org-path connect, pending callback and org-path disconnect tests), then passed again once restored.bun run lintandbun run typecheckinfrontendpass.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.