Repository navigation
Use plain words in the labels around a thread - #432
Merged
abhishekgahlot2 merged 1 commit intoNov 6, 2026
Merged
abhishekgahlot2 merged 1 commit into
abhishekgahlot2 merged 1 commit into
Conversation
Screen reader names and tooltips around a conversation used internal words: "Jump to turn 3", "Peek run", "Loading run", "Open spawned session", "Stops the current turn" and "The runtime does not report which model answered". They only make sense if you built the product. Each now says what the control does in everyday words. - Scroller rail: "Jump to a message" and "Jump to message N: ...". - Thread side pane: the stub header and loading state say Task, the error says task, and the preview button in All threads is "Preview task". - Spawned gateway children are "helper agent" everywhere, through the shared kind label in child-labels.ts; the inline fold now derives its link name from that label instead of a second hardcoded string, so it cannot drift from the Agents rail. - Send now (queue list and pill): "Stops what the agent is doing now and sends this message right away"; the pill reads "sends after the current reply". - Details rail: the row is "Model" and its tooltip says the model the task asked for, and that we are not told which model actually answered. Tests that matched the old strings are updated, and two guard the shared label and the Model row. Closes useagenthq#339
Contributor
|
Merged, thanks @coolestnick. Screen reader names that make sense to someone who didn't build the product is a real accessibility win. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339
The labels that screen readers and tooltips use around a thread were full of internal words (run, turn, session, spawned, runtime). I went through the ones listed in the issue and reworded them.
What changed:
child-labels.tsand is shared by the inline fold, the Agents rail and the group count, so I changed it there once. The fold used to hardcode its own "Open spawned session: ..." link next to that caption; it now builds the link fromchildKindLabelso the two can't drift apart again.queued-message-pill.tsx, so I updated both. The pill reads "sends after the current reply" now.I left alone the tool verb "Run" for shell commands, the
data-run-id/runIdidentifiers, and the "Loading runs" text on other pages, since they're outside this issue.Tests that matched the old strings are updated. I also added two small checks: the fold link has to use
childKindLabel("spawned_session")and never contain "spawned", and the details rail has to render Model, not Runtime.Checks:
cd frontend && bun run test-> 1931 pass, 0 failcd frontend && bun run lint-> no warnings in the changed filescd frontend && bun run build-> okbun run typecheckat the root -> okbun test scripts/agent-docs.test.ts-> 5 passBefore / after
Production build of main next to this branch, same local backend. Native tooltips don't show in screenshots, so those strings are quoted above from the DOM.
Side pane while it loads, opened from All threads:
Details rail:
Queued message pill:
The scroller rail looks the same as before; only its accessible names changed, from "Jump to turn 1: Run the shell command..." to "Jump to message 1: Run the shell command..." on a six-message thread.