Draft
Conversation
rdohms
requested changes
Feb 25, 2021
Member
There was a problem hiding this comment.
Can you please document this in the README?
Also internally, not sure we want to lower our threshold, as these logs have been useful. Right @WyriHaximus ?
Member
@agustingomes And set the current defaults in the
@rdohms At the moment we need these logs to detect certain issues. So yes they are very useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usabilla PHP Docker Template
Reviewers: @usabilla/oss-docker
Type
Please specify the type of changes being proposed:
Changelog
This change aims to add control over the log level outputted by FPM itself. I've noticed we have a high volume of logs with notice level that will look like this:
The new variable added will allow us to control the minimum level we want our FPM processes to log. note that this logging is different than the one from the application itself.