Repository navigation
fix(plugin): clear the plugin directory's policy holds - #84
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the plugin directory's policy holds on
plugin/(validator run on 371b561).Per hold
APPROVEDin plugin.mjs);allowSetting,holdAllowand the allow emission are setup-only;claudeOutwrites only a literalaskordeny. The bundledpolicy.jsonhas no allow outcome, the Hermes adapter (itsapproveis an ask) is left out, and so are the queue approve, deny and clear CLIs. The build now fails on apermissionDecisionother than a literal ask or deny, anapproveaction, or"allow"as a decision outside report.mjs and replay.mjs.iconin plugin.json, no PNG in the bundle.HELM_PASSrenamed. NoANTHROPIC_API_KEY,REFLEX_KEYCHAIN_SERVICEorGH_TOKENin the bundle (build check): the System 2 key comes only from thejudge_api_keyoption.scripts/<name>.sh, plain sh scripts that refuse any argument the command does not list, then run one module with node.allowed-toolsnames those scripts; the gate judges each as thereflexcommand it stands for. The hooks and the MCP server still run node, so this hold is expected to stay for a reviewer.curlis now forbidden everywhere in the bundle). The regexes in rules.json, detectors.json, injection policy.json, fastlane.mjs and autonomy.mjs stay: they are detection patterns.Also left out: the
reflex-shshim, thequeue.notifyshell command, envelope set and clear, checkpoint restore, runaway reset. The plugin README gained reviewer notes.Verification
node scripts/build-plugin.mjs: OK, 62 files.claude plugin validate --strict pluginand.: passed.CLAUDE_PLUGIN_ROOT=plugin node test.mjs --plugin-onlyandnpm test: green.--plugingive identical decision, source and rule.