fix: let --help flag take precedence over parse errors#2360
Merged
Conversation
meatballhat
reviewed
Jun 14, 2026
meatballhat
left a comment
meatballhat
left a comment
Member
There was a problem hiding this comment.
If the addition of the opencode config in this change is intentional, I'd like to understand why 😁
When --help is explicitly provided alongside bad flags, the help output should be shown instead of printing 'Incorrect Usage'. Also update stale comments in helpCommandAction to reflect all actual invocation paths.
…ubcommand help display
meatballhat
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fixes two help invocation inconsistencies related to issue #2126.
--helpflag now takes precedence over parse errors: When--helpis given alongside a bad flag (e.g.app --help --undefined), the help output is now shown instead of printing "Incorrect Usage".Updated stale comments in
helpCommandActionto list all actual invocation paths.Which issue(s) this PR fixes:
Related to #2126
Release Notes