feat: add Command.Walk() and Command.Path() convenience methods#2353
Merged
Conversation
abitrolly
reviewed
Jun 8, 2026
abitrolly
reviewed
Jun 8, 2026
abitrolly
reviewed
Jun 8, 2026
Contributor
|
Strange that |
Co-authored-by: Anatoli Babenia <anatoli@rainforce.org>
dearchap
commented
Jun 8, 2026
dearchap
left a comment
dearchap
left a comment
Contributor
Author
There was a problem hiding this comment.
Addressed feedback on Walk godoc — removed the unclear 'pre-order' phrasing and simplified per suggestion. FullName comment was already updated in prior commit.
Contributor
|
Still not clear what FullName does in Path description. |
Member
|
Missing a |
meatballhat
approved these changes
Jun 12, 2026
abitrolly
reviewed
Jun 17, 2026
| } | ||
| _ = cmd.Walk(func(sub *Command) error { | ||
| for _, subCmd := range sub.Commands { | ||
| subCmd.parent = sub |
Contributor
There was a problem hiding this comment.
Strange that parent is injected only here and not when subCmd is added into sub.Commands array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2324
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
go test -run=TestCommand_Walk
go test -run=TestCommand_Path
Release Notes
(REQUIRED)