Skip to content

[OSS::Avatar] Add new skin argument - #694

Merged
aprentout merged 3 commits into
masterfrom
ap/pyx-195
Jul 24, 2026
Merged

[OSS::Avatar] Add new skin argument#694
aprentout merged 3 commits into
masterfrom
ap/pyx-195

Conversation

@aprentout

Copy link
Copy Markdown
Contributor

What does this PR do?

Related to: #PYX-195

What are the observable changes?

Allow passing different skin for OSS::Avatar
Capture d’écran 2026-07-24 à 14 45 43

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation with Figma design link. Don't forget to replace "design" by "file" in the URL. For example https://www.figma.com/file/example
  • Migrated touched components to Glimmer Components
  • Properly labeled

@aprentout aprentout self-assigned this Jul 24, 2026
@linear-code

linear-code Bot commented Jul 24, 2026

Copy link
Copy Markdown

PYX-195

Comment thread addon/components/o-s-s/avatar.stories.js
Comment thread tests/integration/components/o-s-s/avatar-test.ts Outdated
Comment thread addon/components/o-s-s/avatar.stories.js Outdated
Comment thread addon/components/o-s-s/avatar.ts Outdated
Comment thread app/styles/atoms/avatar.less
<OSS::Avatar @size="lg" @skin="xtd-lime" @initials="E"/>
<OSS::Avatar @size="lg" @skin="primary" @initials="N"/>
<OSS::Avatar @size="lg" @skin="primary-light" @initials="C"/>
<OSS::Avatar @size="lg" @skin="xtd-cyan" @initials="E"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: how do we handle Avatars with 2 ou 3 letters ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply by passing 2 ou 3 letters :trollface:
It already works fine :)
Capture d’écran 2026-07-24 à 16 42 57

@aprentout
aprentout merged commit 16d4a04 into master Jul 24, 2026
5 checks passed
@aprentout
aprentout deleted the ap/pyx-195 branch July 24, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants