feat: added normalize category name service for proper dcns on columns - #271
Open
OwenCoogan wants to merge 1 commit into
Open
feat: added normalize category name service for proper dcns on columns#271OwenCoogan wants to merge 1 commit into
OwenCoogan wants to merge 1 commit into
Conversation
OwenCoogan
requested review from
edouardmisset and
olxmpe
and removed request for
a team
July 31, 2026 13:16
Comment on lines
+3
to
+8
| export function normalizeCategoryNameHelper(params: any[]) { | ||
| const [category] = params; | ||
| return category.toLowerCase().replace(/\s+/g, '_'); | ||
| } | ||
|
|
||
| export default helper(normalizeCategoryNameHelper); |
Contributor
There was a problem hiding this comment.
I usually see helpers defined this way :
formatError = helper((_, { step }: { step: Step }): string => {
return this.errorMessage(step);
});
Is there a specific reason why you wrote this one as a function and exported it as a helper instead? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to : #
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes