Repository navigation
Conversation
The presets bound gf to an editfileoncursor command that did not exist, so the binding was dead and in modal modes vi's gMode swallowed the g anyway. The command reads the path-like token under the cursor (or the visual selection), resolves it as absolute or ~-expanded, then relative to the current file's directory, then the workspace root through the workspace file system, and opens the first match, landing on :line[:column] when given. gf is bound in the vi and helix KeyBindings; the bare gf in command.key_bindings moves to <c-x>f so modeless presets keep a reachable binding. Fixes unstablebuild#145 Generated with Devin (https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Seyamalam <seyamalam41@gmail.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presets bound
gfto aneditfileoncursorcommand that did not exist, so thebinding was dead; in modal modes vi's
gModeswallowed theganyway. The new commandreads the path-like token under the cursor (or the visual selection verbatim), resolves
it as absolute or
~-expanded, then relative to the current file's directory, then theworkspace root, all through the workspace file system so remote workspaces work too, and
opens the first match, landing on
:line[:column]when given.gfis bound invi.KeyBindingsandhelix.KeyBindings, which complete the sequencewhen the editor declines the second key. The bare
gfincommand.key_bindingsmovesto
<c-x>f, since a bare two-letter binding conflicts with typing in modeless presets;the duplicate entry in the dead
tui_cmd_bindingstable is removed.Fixes #145
Created with SWE-2 Max in T3 Code.
Authorship