Repository navigation
Repin ggml-org#24423, ggml-org#25731, unslothai#158, unslothai#149 onto b11609, drop unslothai#152 - #276
Merged
Conversation
… drop #152 (upstream ggml-org#30405)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
danielhanchen
added a commit
that referenced
this pull request
Oct 14, 2026
danielhanchen
added a commit
that referenced
this pull request
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins four pins and drops one so the nightly merges again on the current base tag.
The scheduled nightly (run 38462794625) stopped in Resolve tag with a merge conflict in
examples/diffusion/diffusion-cli.cpp. No pin moved. The base moved from b11541 to b11609, and three upstream changes in that range break five pins:common_chat_params::promptinto acommon_chat_promptand editedformat_input_text(), which the pin deletes.promptuses to.prompt.str()6a7388aac74ab896d9d4f0fb187ddac4847c02f0common/parsers/inkling.cpp:48fails to compile (operator+=oncommon_chat_prompt)data.prompt.append(data.generation_prompt), the same port upstream made inkimi-k2.cpp607b193a546bf7ebd17cca1c3e355c622fcef605ggml_cuda_pinned_memory_disabled()line, the pin's helper now wraps itfb9b9462041ad58cde9a274e7984c3c6fb01b279GGML_CUDA_ENABLE_UNIFIED_MEMORY=0is parsed upstream nowggml_cuda_unified_memory_enabled()at both sites, keep only the once-per-process HIP warning30d39d74fd9cad3224c30bdda3a9def6c9aa6719Each fix is a
--no-ffmerge of b11609 into the pin's own branch (fast-forward pushes, nothing rewritten). The two ggml-org PRs are mergeable with ggml-org master again. #158 and #149 now targetbase/upstream-fcac19079, so their PR diffs are the pin's own change again (+24/-1 and +19/-0).One behaviour change comes from following upstream in #149:
GGML_CUDA_ENABLE_UNIFIED_MEMORY=true,yesandonare now read as off, because upstream parses the value withatoi.Changes
scripts/unsloth/pr-set.json: repins ggml-org#24423, ggml-org#25731, ggml-cuda: avoid direct ROCm_Host compute on HIP integrated GPUs (port of ggml-org#25863) #158 and HIP: say once that GGML_CUDA_ENABLE_UNIFIED_MEMORY is on #149 to the SHAs above and removes llama: map each contiguous run of a context's tensors, not one span over all of them #152.scripts/unsloth/feature-checks.json: removesunslothai#152fromuncheckedand rewrites theunslothai#149reason (the pin is now only the HIP warning).Checks
dup=1casesdup=1casesThe MUL_MAT_ID
dup=1cases crash the same way on the plain upstream tag (4 f16n_mats=28cases, then an illegal memory access inmmq.cuh); they come from ggml-org#29998, so they are not caused by the pins.Numeric gate for the two model pins (old head A, new head B, new head merged with ggml-org master C):
Not covered