Repository navigation
unsloth: drop the pins upstream superseded and repin the conflict-fixed heads #242
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,9 +52,9 @@ | |
| ] | ||
| }, | ||
| "glm5next": { | ||
| "owner": "unslothai#239", | ||
| "checks": [ | ||
| { "kind": "arch", "arch": "glm5-next" }, | ||
| { "kind": "backend-op", "op": "LIGHTNING_INDEXER" } | ||
| ] | ||
| }, | ||
|
|
@@ -80,7 +80,7 @@ | |
| ] | ||
| }, | ||
| "qwen4exp-mtp": { | ||
| "owner": "unslothai#240", | ||
|
There was a problem hiding this comment.
When #240 is responsible for making the shared MTP sidecars work, assigning it this feature check provides no coverage for that behavior: Useful? React with 👍 / 👎. |
||
| "checks": [ | ||
| { "kind": "arch", "arch": "qwen4exp" }, | ||
| { "kind": "backend-op", "op": "TOPK_QSA" } | ||
|
|
@@ -95,10 +95,10 @@ | |
| }, | ||
| "unchecked": { | ||
| "unslothai#95": "sampling penalties indexed by token id; behaviour is covered by test-sampling, and there is no feature surface of its own to probe", | ||
| "unslothai#149": "GGML_CUDA_ENABLE_UNIFIED_MEMORY=0 env parsing; needs a CUDA or HIP host, and no runner in the pipeline has one", | ||
| "unslothai#152": "per-run mmap of a context's tensors; a memory-layout change with no observable output difference", | ||
| "unslothai#157": "cudaMemcpyDefault in the ggml_cuda_cpy 2D fast path; needs a CUDA host", | ||
| "unslothai#158": "ROCm_Host compute buffer type on HIP integrated GPUs; needs a ROCm host", | ||
| "unslothai#241": "CUDA graph cache key, macOS row prefetch, F16 glm5-next indexer cache under a quantized -ctk and the glm5-next NextN draft graph; the first needs a CUDA host, the second has no observable output difference, the last two need a real GLM-5-Next NextN head with --spec-type draft-mtp" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
unslothai#239is needed to keep existing GGUFs whosegeneral.architectureisglm5nextloadable, replacing this probe withglm5-nextexercises only the new upstream path. A regression in the compatibility path added by #239 could therefore ship while this feature remains green; keep a separateglm5nextcheck alongside the upstream-name check.Useful? React with 👍 / 👎.