Repository navigation
feat(bash)!: simplify the async tool surface - #19
Open
unrelentingfox wants to merge 2 commits into
Open
unrelentingfox wants to merge 2 commits into
unrelentingfox wants to merge 2 commits into
Conversation
Remove the separate bash_async tool so every shell command runs through the permission-checked bash tool name. Start async work with bash and run_async=true; the name parameter becomes description. notify suppresses the terminal notification for run_async starts only, while a command backgrounded from the foreground always notifies. With run_async, timeout is the decision timeout resolved by bash_async_decide; foreground timeout still auto-backgrounds. Delete the unused async call renderer.
Reduce the tool surface to bash and bash_async. Remove the bash_async decide and watch tools plus the async decision-timeout flow, so bash timeout is foreground-only and is ignored with run_async=true. Rename the job-management tool bash_async_list to bash_async, and drop the machinery the removed tools left behind. Start async work with bash and run_async=true.
unrelentingfox
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reduces the extension to two tools:
bashandbash_async.bash— the shadowed Bash tool. Foreground by default;run_async: truestarts detached work;descriptionlabels the job;notify: falsesuppresses the terminal notification forrun_asyncstarts.timeoutapplies to the foreground path (auto-background, or kill when not auto-background-eligible) and is ignored withrun_async.bash_async— job management, renamed frombash_async_list:list,output,kill,attach,search,cleanup,stats.All shell execution now goes through the
bashtool name thatpi-permission-systeminspects.Removed
bash_async(start tool)bashwithrun_async: truebash_async_listbash_asyncbash_async_watchbash_async_decidemonitor*modules)The dead machinery those tools left behind is deleted too:
Job.kind,Job.stop, the job-id kind prefixes, the split-stderrerrPathpath,EVENT.monitorEvent, theMONITOR_*constants, the monitor/kind render and notify branches, and the now-unreachable notification overrides.Breaking changes
bash_asyncis gone. Start async work withbashandrun_async: true.bash_async_list,bash_async_watch, andbash_async_decideare gone.bash_asyncnow names the job-management tool.timeoutno longer applies to asynchronous jobs.Slash commands
/bash-asyncand/bash-async-listare unchanged.Validation
pnpm run check: 191 tests pass, 0 fail,tsc --noEmitclean, package payload verified.