feat: add node-redis driver (#664)#665
Open
cjpearson wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 59.99% 63.81% +3.81%
==========================================
Files 42 44 +2
Lines 3657 4043 +386
Branches 590 701 +111
==========================================
+ Hits 2194 2580 +386
Misses 1460 1460
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bbdd31a to
2de074e
Compare
f987c71 to
dbc4752
Compare
dbc4752 to
50368e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#664
This adds a new driver for redis using the
node-redislibrary.It's mostly based off of the existing redis driver which uses ioredis. But there are a few differences:
scanrequires some different handling for cluster mode Scan Iterator onRedisClusterredis/node-redis#2657getInstanceon the driver, so I've left it out.RedisClientTypetype is slow to typecheck (TS performance issue) redis/node-redis#2975setItemRawandgetItemRawuse typeMapping which is a feature of node-redis