Fixes infinite rerender trigger loop in setup screen#23
Open
flleeppyy wants to merge 1 commit into
Open
Conversation
Member
|
can you confirm if the code I pushed fixed this issue for you? At least in my repro, it worked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes like, 2 main things. Most important one was a repeated render call due to
showErrorbeing a dependency in a useEffect. It also fixes showError and related functions not using useCallback and useMemo on context value, which caused a rerender every time one of its functions are called.Here is an example of the issue involving a useEffect having showError as a dependency
BIG FAT EPILEPSY WARNING!!!
pudu-launcher_Bk509G9LyR.mp4
And here is the second issue concerning the FeedbackContext's exposed context functions not being wrapped in useCallback.
pudu-launcher_rHPAi8sQq2.mp4