Avoid repeated predicates in PDDL domain generation#2
Open
francescobozzo wants to merge 1 commit intounitn-ASA:masterfrom
Open
Avoid repeated predicates in PDDL domain generation#2francescobozzo wants to merge 1 commit intounitn-ASA:masterfrom
francescobozzo wants to merge 1 commit intounitn-ASA:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for deliveroojs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already addressed in #1:
Deliveroo.js/packages/@unitn-asa/pddl-client/src/PddlDomain.js
Line 32 in df18cdf
Even after the fix has been implemented, if I am not wrong, this operation should be performed only a single time for each predicate with the same name. Therefore, if we find both
(light ?l) (light ?m) (light ?l-with-different-len), the push action should be executed only when processing the first predicate occurence.Please, consider the fact that to run my project, (developed alongside with my teammate @fedeizzo), the fix in this Pull Request is required