ci: book-only pull requests skip the build and tests - #9
Merged
Merged
Conversation
Every pull request built and tested the whole workspace on five engines, two systems and four browser shards, the Windows run alone taking half an hour, even when all it changed was a page under landing/ or the README. A changes job now says whether anything else was touched. When nothing was, the heavy jobs are skipped - by job for fmt, js, clippy, no-engine, semver and browser, and by step for the engine and test matrices, whose required checks would otherwise be reported under a name the branch protection does not wait for - and docs, which runs cargo xtask book --check, runs as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test_debouncer_persistence slept 500 ms after a 50 ms debounce and read the value straight after, so a loaded Windows runner whose commit had not landed by then failed it. It now reads until the value is there, for up to 20 s; a debounce that never fires still fails it, with None against Some(8080). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous commit went out with the one-hour debounce used to check that the test fails when nothing lands on its own, which makes it fail every time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request that changes only
landing/orREADME.mdskips the build and test jobs;docs, which runscargo xtask book --check, still runs. The engine and test matrices skip by step rather than by job, so their required checks still report under the names branch protection waits for.🤖 Generated with Claude Code